feat: improve ssr html mismatch validation #10658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 28d5bf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Feb 28, 2024
packages/svelte/tests/runtime-runes/samples/invalid-html-ssr/_config.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon H <[email protected]>
Co-authored-by: Simon H <[email protected]>
thebjorn
reviewed
Mar 2, 2024
| 'which may result in content being shifted around and will likely result in a hydration mismatch.'; | ||
| // eslint-disable-next-line no-console | ||
| console.error(message); | ||
| payload.head.out += `<script>console.error(${message})</script>`; |
There was a problem hiding this comment.
It’s already a string though?
There was a problem hiding this comment.
yes, but you're generating code (the script tag), and in code strings must be quoted (you probably need to sanitize the message for the quotes you'll be using too...)
There was a problem hiding this comment.
You're right, published a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides HTML validation for during DEV when we server side render the content. If any errors are found we
console.errorboth on the server and on the client (we inject a<script>tag with theconsole.errorinto the head).